tree 4d1783d6784997ae814779933a91b8683f3dedf4
parent d389823656a117e2c0327ae58e63b6fdae7deb46
author Bruno Dal Bo <brunodalbo@google.com> 1618241325 +0000
committer CQ Bot <commit-bot@chromium.org> 1618241325 +0000

Revert "[opaque_test] Injection & Interposition on new thread"

This reverts commit 3eb3e2115be077b6361833473b48d516951d2a9a.

Reason for revert: Servicing the event streams on spawned threads cause all the channels created on that thread to misbehave once the thread is gone.

Bug: 73644
Multiply: fuchsia_component_v2_test: 30

Original change's description:
> [opaque_test] Injection & Interposition on new thread
>
> Sometimes test writers need to do thread sleeps or connect
> to services. These operations are blocking.
>
> If the main thread is blocked, injection and interposition
> will stop working. This may lead to a deadlock scenario.
>
> For example, consider the following scenario:
> * A test injects a service for component `foo`.
> * The test connects to an outgoing service of `foo`.
>   This blocks the main thread until `foo`s outgoing directory is
>   available. While the main thread is blocked, injection does not work.
> * Before serving the outgoing directory, `foo` connects to the
>   injected service. This creates a deadlock scenario.
>
> To solve this problem, each injector + interposer is run on a new
> thread.
>
> Change-Id: I4d91252e664861388a3d116641931ea4a28fd576
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/435340
> Reviewed-by: Fady Samuel <fsamuel@google.com>
> Testability-Review: Fady Samuel <fsamuel@google.com>
> Commit-Queue: Xyan Bhatnagar <xbhatnag@google.com>

Change-Id: Ia4d47148e13c4bcb941cb935775d5b354018dfe3
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/513764
Reviewed-by: Bruno Dal Bo <brunodalbo@google.com>
Reviewed-by: Fady Samuel <fsamuel@google.com>
Reviewed-by: Xyan Bhatnagar <xbhatnag@google.com>
Fuchsia-Auto-Submit: Bruno Dal Bo <brunodalbo@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>