| commit | 6a89473e2c1595af40a4fabc93576c324a47e0eb | [log] [tgz] |
|---|---|---|
| author | Tim Detwiler <tjdetwiler@google.com> | Fri Apr 03 22:09:58 2020 +0000 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Fri Apr 03 22:09:58 2020 +0000 |
| tree | 040c9a7e141324040565b64ae11c8c5eff9e8643 | |
| parent | 204094d0977ff723faf1ce042017e45e3107b6a8 [diff] |
[audio_core] Simplify TLFunctions in OutputPipeline
We were doing some complex linking of TimelineFunctions between mix
stages. This is a hold-over from when all the mix stages ran in
lock-step (so we used the same TimelineFunction for all stages).
In reality, we can create new TimelineFunctions for the intermediate
stages instead. This makes things simpler and easier to reason about.
In addition this fixes a bug where loopback can be silent when running
mix stages at different rates.
Test: fx test -o audio_core_unittests
> Added a new unit tests for Loopback + Upsample that fails before
this patch is applied. We also improve these tests so that we
don't verify the loopback streams against silence, which made
it impossible to test that we were looping back properly.
Change-Id: I44df76662551ea1482efb6855c4793baea823618
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/377234
Commit-Queue: Tim Detwiler <tjdetwiler@google.com>
Reviewed-by: Martin Puryear <mpuryear@google.com>
Testability-Review: Martin Puryear <mpuryear@google.com>
Pink + Purple == Fuchsia (a new operating system)
Fuchsia is a modular, capability-based operating system. Fuchsia runs on modern 64-bit Intel and ARM processors.
Fuchsia is an open source project with a code of conduct that we expect everyone who interacts with the project to respect.
See Getting Started.
See fuchsia.dev.