| commit | 08538949e16ed364a26b876333cf9b973500f2ac | [log] [tgz] |
|---|---|---|
| author | Parag Dixit <paragdixit@google.com> | Tue Apr 13 03:04:10 2021 +0000 |
| committer | CQ Bot <commit-bot@chromium.org> | Tue Apr 13 03:04:10 2021 +0000 |
| tree | 20ccf73df70592325e7988dbc388caa9e51f619d | |
| parent | 26a3d2bbaa8fe128c738b7680b7fe00b6f15fa31 [diff] |
[build] Fixing hermetic deps in fidlc Fixed detection of hermetic deps issue by creating a dep_file in fidlc. Currently, the action which launches fidlc reads from some files which are not its inputs, and can't be added as inputs as the files are not known at gen time. For such cases, tools like fidlc should generate a dep file mapping their outputs to list-of-inputs, so that build system can check for individual action's hermeticity. The fidlc works incrementally correctly without this change, but build system can't check that. Updated gen_response_file to add depfile related arguments in the response file. Removed hermetic_deps suppression. See: https://fuchsia.dev/fuchsia-src/development/build/hermetic_actions?hl=en https://fuchsia.dev/fuchsia-src/contribute/open_projects/build/hermetic_actions?hl=en After this change we continuously verify that fidlc invocations are incrementally correct. Bug: 74204 Change-Id: Ia06d1a7fa8d4f3af9ee3c81562cbcb7fb0815e83 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/513027 Commit-Queue: Shai Barack <shayba@google.com> Reviewed-by: Shai Barack <shayba@google.com> Reviewed-by: Pascal Perez <pascallouis@google.com>
Pink + Purple == Fuchsia (a new operating system)
Fuchsia is a modular, capability-based operating system. Fuchsia runs on modern 64-bit Intel and ARM processors.
Fuchsia is an open source project with a code of conduct that we expect everyone who interacts with the project to respect.
Read more about Fuchsia's principles.
See Getting Started.
See fuchsia.dev.