tree 47b96d50cbd739613bc799625a520a9b41db38a6
parent 2bc804e44dc42f15cad63fcda2dac051d86c961d
author John Grossman <johngro@google.com> 1588292797 +0000
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> 1588292797 +0000

[fbl][wavl] Remove a useless and incorrect using directive.

There is no real reason for the generic node_state fetcher in WAVL
tree to have a RankType using alias.  In addition, this alias was
incorrect.  It was missing the TagType parameter for the node_state
template which caused it to incorrectly fall back on the default tag.
This would only be caught when attempting to instantiate a tree of
objects which used the ContainableBaseClasses pattern, but no default
WAVLTreeContainable mix-ins.

Also, add new tests which would have caught this in the first place,
and fix an existing test which was broken and caught by the new test
augmentations.

Test: new tests
Change-Id: If7a83d749feeaf16588ad85fc3ad2fb767b95b9c
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/383486
Commit-Queue: John Grossman <johngro@google.com>
Reviewed-by: Nick Maniscalco <maniscalco@google.com>
Testability-Review: Nick Maniscalco <maniscalco@google.com>