tree 23e7ccb6117edbfc6517c4afd2bf0ee2e844546f
parent 38f6002fecb6f971c989cae7fc17e96cb43d5009
author Joshua Seaton <joshuaseaton@google.com> 1579309920 +0000
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> 1579309920 +0000

[botanist] Refactor

Botanist has grown unwielidy over the past ~year and so this change
returns it to a more manageable and scalable state. Much of the weight
loss is due to the removal of log support in the multi-device case, which -
interestingly - has not been used at all or relied upon since its introduction!
(Indeed, we are creating files (with %d suffixes that we have up front
not registered as task outputs, and so they never get shipped back to
the recipe).)

Also removed was botanist's care for not having streamed empty log
content. This seems like something that should more reasonably be
checked in the context of a recipe rather than something botanist should
intimately care about.

Tested: botanist is extensively integration tested being the tool that
CQ itself consumes from source to run tests and manage device
interaction. Also, this change can be viewed as bootstrapping
testability for a more streamlined botanist codebase.

Change-Id: I5809ec79e745339a4b970f8a109e2bb47fe2eef9