)]}' { "log": [ { "commit": "efa925c74f2ea63033360992c81d2e89dccd3535", "tree": "236a1c86c2606949a68aac6011b6a907320b6eab", "parents": [ "e1c8dfd93e94bc48265a1441f14cf73306522f00" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Aug 26 20:51:41 2024 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Aug 26 20:51:41 2024 +0000" }, "message": "Update README\n\nChange-Id: Ia703fef39d87a1fb9ba2b3123a1378468206a618\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/1105164\nReviewed-by: Ian McKellar \u003cianloic@google.com\u003e\n" }, { "commit": "e1c8dfd93e94bc48265a1441f14cf73306522f00", "tree": "9999c609d45aae836f069319437847c466f1d34d", "parents": [ "bd8f69c2a691c9237c4a6b28818d21594ccdb2d3" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Aug 26 20:51:41 2024 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Aug 26 20:51:41 2024 +0000" }, "message": "Update everything\n\n* Docker images\n* NPM dependencies\n* Go version\n\nSimilar to what I did in Iaea40bbfb9335f6897e535a7eb1d7e9ce641f12d.\n\nTest: manually tested with \u0026 without docker\nChange-Id: I86b3e7eb1ea0926385afedae97b1042e78254914\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/1105163\nReviewed-by: Ian McKellar \u003cianloic@google.com\u003e\n" }, { "commit": "bd8f69c2a691c9237c4a6b28818d21594ccdb2d3", "tree": "bf4c9562378f8e6af7f32cb07b1979b2ec5ca893", "parents": [ "36da529e55fcc80ff8cbbec975602d2e73214d79" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Aug 26 20:51:41 2024 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Aug 26 20:51:41 2024 +0000" }, "message": "Self-host Ace editor instead of using CDN\n\nThis should make it easier to embed fidlbolt in more places in the\nfuture, and removes our reliance on a 3rd party CDN.\n\nThe Ace editor is pretty difficult to use with npm and bundlers but I\nmanaged to get it working. It bundles the main Ace code and all the\nmodes we need (JSON, C++, etc.) into main.js, and copies all the themes\nand keybinding .js files to be loaded on demand.\n\nChange-Id: I53ff86bc8cdfb9d6edf87a22367d028bdd9b4d73\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/1105162\nReviewed-by: Ian McKellar \u003cianloic@google.com\u003e\n" }, { "commit": "36da529e55fcc80ff8cbbec975602d2e73214d79", "tree": "ab604e8ca0b9016a00b1ebfa4c5fcd229a9e57bd", "parents": [ "675944a6798d0c0e2989605f2211b246f5723f74" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Aug 26 20:51:41 2024 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Aug 26 20:51:41 2024 +0000" }, "message": "Remove code supporting the old name \"llcpp\"\n\nIt\u0027s been two years since the rename so this isn\u0027t going to break any\nclients.\n\nFixed: 42057940\nChange-Id: I33798747352474730173626ecbd3646a17b7e107\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/1105161\nReviewed-by: Ian McKellar \u003cianloic@google.com\u003e\n" }, { "commit": "675944a6798d0c0e2989605f2211b246f5723f74", "tree": "c121e3f9c7e961542fcf94866fa528350dca4a0d", "parents": [ "0673759be55ab4e43a7a533aa2c35d14a75bc678" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Jun 18 01:14:07 2024 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Jun 18 01:14:07 2024 +0000" }, "message": "Update links and remove old news items\n\nChange-Id: I15629969c36caee81c87e7a0f0df3de6e63cf7a6\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/1066203\nReviewed-by: Ian McKellar \u003cianloic@google.com\u003e\n" }, { "commit": "0673759be55ab4e43a7a533aa2c35d14a75bc678", "tree": "e3dcfedf1ce141fdf3b17a61ab01005a36056de0", "parents": [ "18eabc4c149d5201f3432ecae983647bd94a6a17" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Jun 18 01:14:07 2024 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Jun 18 01:14:07 2024 +0000" }, "message": "Move layout into settings\n\nThis removes the \"Layout\" button (which was confusingly short for\n\"toggle horizontal/vertical layout\"), replacing it with a dropdown in\nsettings that can be Auto (default), Horizontal, or Vertical. The Auto\nlayout is horizontal for narrow windows and vertical for wide windows.\n\nI also moved the Help button to the top right because I think it looks\nbetter that way.\n\nTest: tested manually\nChange-Id: I75eac5545594f484371f228bc8431e5f64c3af9b\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/1066202\nReviewed-by: Ian McKellar \u003cianloic@google.com\u003e\n" }, { "commit": "18eabc4c149d5201f3432ecae983647bd94a6a17", "tree": "537f7263bf6baf9639e220a9686057d662624354", "parents": [ "c22a324589835af8b3b29717b17f35555501b468" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Jun 11 17:29:43 2024 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Jun 11 17:29:43 2024 +0000" }, "message": "Allow multiple versions in --available\n\nAlso allow NEXT.\n\nChange-Id: I45b09bec8e6519baff9f15e58d2bdbf57b4b74b9\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/1063673\nReviewed-by: Ian McKellar \u003cianloic@google.com\u003e\n" }, { "commit": "c22a324589835af8b3b29717b17f35555501b468", "tree": "03d7af06c2379b4854b52e0107e02e5a0dede7d4", "parents": [ "d16582b70d6006a87d26c9b2fc820191a1ad60b3" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Jun 10 20:13:48 2024 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Jun 10 20:13:48 2024 +0000" }, "message": "Switch from Webpack to esbuild\n\nBecause I was running into webpack errors, and esbuild is way faster.\n\nAlso removed eslint prettier plugin in favor of the simpler config\napproach, as recommended on\nhttps://prettier.io/docs/en/integrating-with-linters.html.\n\nTest: Manually tested with and without docker\nChange-Id: I78edd5bd8401c92d3655f4c620acb4ac5fdeb9f3\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/1062533\nReviewed-by: Ian McKellar \u003cianloic@google.com\u003e\n" }, { "commit": "d16582b70d6006a87d26c9b2fc820191a1ad60b3", "tree": "5ba8227217f0b124cb8928778466a4c32a85f997", "parents": [ "80ddb568a2f8bd5be79fc135029b91b96f36ddef" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Apr 24 17:27:11 2024 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Apr 24 17:27:11 2024 +0000" }, "message": "Change ryannhg/date-format to ryan-haskell/date-format\n\nThe build was failing because the GitHub user changed their username:\nhttps://discourse.elm-lang.org/t/ryannhg-packages-renamed-to-ryan-haskell/9705\n\nConfusingly, 1.0.0 is the latest (and only) version in the registry:\n(https://package.elm-lang.org/packages/ryan-haskell/date-format/latest/.\nThe GitHub repo has 2.3.0 tagged on a much older commit.\n\nChange-Id: Ib3b20e65a7d39cd3df8f8ffe76d4d66cbd644b51\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/1035992\nReviewed-by: Clayton Wilkinson \u003cwilkinsonclay@google.com\u003e\n" }, { "commit": "80ddb568a2f8bd5be79fc135029b91b96f36ddef", "tree": "c8e442753e82a0d9e3daac62ed0e209005787fa8", "parents": [ "dc6aa7df95cf66fe52049f8f35fd61f9acaa2f48" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Mar 19 16:07:53 2024 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Mar 19 16:07:53 2024 +0000" }, "message": "Remove --experimental transitional_allow_list\n\nThis flag was removed from fidlc in https://fxrev.dev/1000412.\n\nChange-Id: Iaa7c1a03fef7988bc32b7f87236d189b35254535\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/1009608\nReviewed-by: Clayton Wilkinson \u003cwilkinsonclay@google.com\u003e\n" }, { "commit": "dc6aa7df95cf66fe52049f8f35fd61f9acaa2f48", "tree": "45a59829860b11cf554d7695015e0dd138fb5241", "parents": [ "37c9baadd2080f425d299c5c9a7ddf199c12171c" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Feb 15 21:37:08 2024 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Feb 15 21:37:08 2024 +0000" }, "message": "Update everything\n\n* Docker images\n* NPM dependencies\n* Go version\n\nTest: manually tested building and running docker container\nChange-Id: Iaea40bbfb9335f6897e535a7eb1d7e9ce641f12d\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/992221\nReviewed-by: Clayton Wilkinson \u003cwilkinsonclay@google.com\u003e\n" }, { "commit": "37c9baadd2080f425d299c5c9a7ddf199c12171c", "tree": "c369114fc7f148a3efc38f8ae266de84be76b80c", "parents": [ "3a8376e6c1c5b33c0fae716a55bdf631692eef36" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Feb 13 18:15:37 2024 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Feb 13 18:15:37 2024 +0000" }, "message": "Fix fidlgen_dart logic\n\nBefore, the hasFidlgenDart flag was always false by mistake. I changed\nit to just test fidlgenDart \u003d\u003d \"\" instead of having a separate flag.\n\nChange-Id: Ic4e0faee38e227d5ae7bf9787cb501e4fff891ed\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/990713\nReviewed-by: Clayton Wilkinson \u003cwilkinsonclay@google.com\u003e\n" }, { "commit": "3a8376e6c1c5b33c0fae716a55bdf631692eef36", "tree": "1b18757f0e214dc315b2ae103ca891e2cc7cb4bb", "parents": [ "fc2e3158bcc3dbe02fb0bb7fd22c9f2350d809b2" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Jan 23 21:26:20 2024 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Jan 23 21:26:20 2024 +0000" }, "message": "Use the coding tables from fidlgen_hlcpp\n\nThe coding tables have been produced by fidlgen_hlcpp instead of fidlc\nsince I21cc21085d826b61b589b53f64c272dd298bebbe.\n\nBug: b/42115242\nChange-Id: I89140d0bb75e4a5ad510213485f3ca76121a1f2c\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/978237\nReviewed-by: Ian McKellar \u003cianloic@google.com\u003e\n" }, { "commit": "fc2e3158bcc3dbe02fb0bb7fd22c9f2350d809b2", "tree": "3158c19fba12b59fa69a7eea8735a29296184921", "parents": [ "412288b2bf8bcd9a4668d8f5bfbe17e91baa5eda" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Dec 04 23:10:54 2023 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Dec 04 23:10:54 2023 +0000" }, "message": "Make fidlgen_dart optional\n\nThis makes the fidlgen_dart binary optional, and shows an error in the\nclient if it isn\u0027t available. This will unblock deploying fidlbolt\nregularly again, since fidlgen_dart isn\u0027t in fuchsia.git anymore.\n\nI made the Makefile accept a FIDLBOLT_PATH environment variable to\nspecify additional search paths for `make run DEPLOYMENT\u003d0`, which I can\nuse to specify a local path to fidlgen_dart.\n\nI also updated the experimental flags passed to fidlc to match the\ncurrent defaults in fuchsia.git.\n\nChange-Id: I1aebf953d3526188fc1cde099d4a1e86d4156e45\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/955452\nReviewed-by: Ian McKellar \u003cianloic@google.com\u003e\n" }, { "commit": "412288b2bf8bcd9a4668d8f5bfbe17e91baa5eda", "tree": "bd036c317ba9926c02e53c9bfac3325b43bfa364", "parents": [ "96120622f39474f659ed26436d74dd657408d73c" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Jun 26 20:21:10 2023 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Jun 26 20:21:10 2023 +0000" }, "message": "Use fuchsia:HEAD version by default\n\nThis changes the version selection text field to contain \"fucshia:HEAD\"\nby default, since https://fxrev.dev/864297 made the --available flag\nmandatory. This avoids the friction of having to type that manually to\navoid getting an error when importing an SDK library.\n\nChange-Id: I369101090c08aff086d0734d2958b83fdc1a5568\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/876838\nReviewed-by: Clayton Wilkinson \u003cwilkinsonclay@google.com\u003e\n" }, { "commit": "96120622f39474f659ed26436d74dd657408d73c", "tree": "44f4769f88c781439a41d5b0fe747960e2a69554", "parents": [ "b80ed5880837c82a00a03667e670233c65c85a81" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Feb 14 23:59:37 2023 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Feb 14 23:59:37 2023 +0000" }, "message": "Remove C tab\n\nThis CL removes the C bindings tab since we have ended C bindings\nsupport. Also removes \"tables.c\" from the C++ tab since the new C++\nbindings do not use coding tables, only HLCPP does.\n\nBug: 95833\nChange-Id: I95a86cbc383a6c7b2519bce95e0dad0abecf689a\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/803307\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "b80ed5880837c82a00a03667e670233c65c85a81", "tree": "2a7adaccc468663c86940e294220be0074846366", "parents": [ "65dc98de5ab94a719bb38982e39b6aaf4117a838" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Jan 12 23:09:09 2023 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Jan 12 23:09:09 2023 +0000" }, "message": "Copy shared libraries required by rustfmt\n\nOur prebuilt rustfmt is now dynamically linked, so we need to copy .so\nfiles into the Docker container for it to work.\n\nTest: ./prepare_deployment.sh\nChange-Id: I0bfd33bb477ab7352b6e13bb360e58c56c51f570\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/789187\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "65dc98de5ab94a719bb38982e39b6aaf4117a838", "tree": "756a4fdcef7eb934b1a240ae70d01cce42030120", "parents": [ "a8a59691c2140462822a47e10e00381bf21d1e13" ], "author": { "name": "Zachary Stewart", "email": "zstewart@google.com", "time": "Fri Dec 16 17:33:05 2022 +0000" }, "committer": { "name": "Zachary Stewart", "email": "zstewart@google.com", "time": "Fri Dec 16 17:33:05 2022 +0000" }, "message": "[fidlbolt] enable unknown interactions flag\n\nChange the experiments passed to fidlc to add the `unknown_interaction`\nflag. This enables unknown interactions in migration mode (closed/strict\nas defaults).\n\nBug: 88366\nChange-Id: Ifec128b6a86fd5038df88078b172f5aa35dcfef4\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/778802\nReviewed-by: Mitchell Kember \u003cmkember@google.com\u003e\n" }, { "commit": "a8a59691c2140462822a47e10e00381bf21d1e13", "tree": "b4d1d185f5007b9de8e00105f0e9b816857d74da", "parents": [ "364a9d6979fa5e4a05c89b255e10232ef6a91df2" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Nov 16 23:29:24 2022 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Nov 16 23:29:24 2022 +0000" }, "message": "Don\u0027t select all text when loading share link\n\nTested manually.\n\nChange-Id: I00947f8d949879b12167e9922c94c1593c4dace6\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/761604\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "364a9d6979fa5e4a05c89b255e10232ef6a91df2", "tree": "7a7881800558a55c897fbebaabf8d8bf6ce8898c", "parents": [ "6596a8096abd519c60901ae0ca09abd67078bd1d" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Nov 16 23:29:19 2022 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Nov 16 23:29:19 2022 +0000" }, "message": "Add help entry for Share button\n\nChange-Id: I11eb7d93731192ead9e17aeb495bcb3faf6b4356\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/761603\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "6596a8096abd519c60901ae0ca09abd67078bd1d", "tree": "5772821e8a0628acbde69d98a47914afa580009d", "parents": [ "676bfc40652c9630f9ba6d5f949ed5c80ff05cf7" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Nov 16 23:29:12 2022 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Nov 16 23:29:12 2022 +0000" }, "message": "Fix caching\n\nThis CL makes fidlbolt use cache-busting for bundle.js and style.cc, and\nno-cache (i.e. require revalidation of caches) for index.html. This\nshould make deployments take effect immediately without requiring anyone\nto force refresh.\n\nTested manually and confirmed the server issues 304 based on\nIf-Modified-Since, and then 200 after modifying index.html. Also\nconfirmed that changing js/css changes the hashes and they don\u0027t get\nserved from cache in that case.\n\nChange-Id: Ib4f678e518f337b7d50a64ebc3e2dd234261c8df\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/761602\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "676bfc40652c9630f9ba6d5f949ed5c80ff05cf7", "tree": "80d430cddca438f27f2a5a597978c09823497dc0", "parents": [ "295916ef1ae4c1f5f68022614b60ef3a567de002" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Nov 16 20:15:21 2022 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Nov 16 20:15:21 2022 +0000" }, "message": "Fix webpack.config.js config vars\n\nIt was using the wrong argv so production was never true.\n\nTested manually and confirmed the share links now use \"go/fidlbolt\"\nin the production build.\n\nChange-Id: I3f63a32f1bf254612a851fe72f9b62a5a7f3f61d\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/761302\nReviewed-by: Matt Hamrick \u003cmjhamrick@google.com\u003e\n" }, { "commit": "295916ef1ae4c1f5f68022614b60ef3a567de002", "tree": "0ab99acd8a5215c11cbf4241da88b3913fda6069", "parents": [ "e507b68ffef14c1086f4b983c778fc30551b198e" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Nov 16 19:32:02 2022 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Nov 16 19:32:02 2022 +0000" }, "message": "Upgrade Dockerfile to use Node 18, Alpine 3.16, glibc 2.34\n\nAfter Idb581ec0502a3d7505300f10719412f21b0b8678 which upgraded npm\ndependencies, building the Docker container is no longer working because\nit was still using Node 10. Upgraded it and the base alpine-glibc image,\ntested manually building an image and running the container.\n\nChange-Id: Id3a30da5dd96523f0e0675d2d9b94a24a52628d1\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/761227\nReviewed-by: Matt Hamrick \u003cmjhamrick@google.com\u003e\n" }, { "commit": "e507b68ffef14c1086f4b983c778fc30551b198e", "tree": "e7ec866e0d11a10dc808c5bf1495941c30461bef", "parents": [ "a3432e2128cee71ae7f6a2d61e8a715e611cfd80" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Nov 16 19:31:56 2022 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Nov 16 19:31:56 2022 +0000" }, "message": "Upgrade from Go 1.17 to Go 1.19\n\nTested manually.\n\nChange-Id: Ie38b479bd0bf0d52a4fa6a0f3b3dd08af57afe32\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/761226\nReviewed-by: Matt Hamrick \u003cmjhamrick@google.com\u003e\n" }, { "commit": "a3432e2128cee71ae7f6a2d61e8a715e611cfd80", "tree": "86157413bfd64c1fed7b21fa35cee383d0e9f4bd", "parents": [ "642bb3ff1b5d0de96a51ffde500463517bcc11ea" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Nov 16 19:31:50 2022 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Nov 16 19:31:50 2022 +0000" }, "message": "Bump Ace from 1.4.12 to 1.13.1\n\nSee https://github.com/ajaxorg/ace/blob/master/CHANGELOG.md for the\nchanges. There are many, mostly bug fixes.\n\nTested manually, including changing all the settings in the settings\nwindow and verifying they worked.\n\nChange-Id: I54c6c788be5838b0a4b000ebafc36a3a30c15f21\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/761225\nReviewed-by: Matt Hamrick \u003cmjhamrick@google.com\u003e\n" }, { "commit": "642bb3ff1b5d0de96a51ffde500463517bcc11ea", "tree": "6acacace21531cf7910ca57abbfb145b53c85798", "parents": [ "e298eae20d7178e8c159a579bb2d899437dc5fe1" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Nov 16 17:48:20 2022 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Nov 16 17:48:20 2022 +0000" }, "message": "Add support for link sharing\n\nThis CL adds the ability to share fidlbolt links. It encodes the entire\nFIDL text in the URL, using the lz-string library for compression.\n\nIf you open a share link and close it without editing, it won\u0027t affect\nthe local storage state. If you edit it, it will be saved to local\nstorage (but you can still undo back to your previous state). This is\nreflected in the address bar: when you start typing, the query parameter\ngoes away (and so if you refresh, it won\u0027t reload it).\n\nChange-Id: I2d132d7fd1406fd2b0d3495d8991554586fc9a6a\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/760143\nReviewed-by: Matt Hamrick \u003cmjhamrick@google.com\u003e\n" }, { "commit": "e298eae20d7178e8c159a579bb2d899437dc5fe1", "tree": "f86f682d667ba9dd46f0f2d88a0518b56d373e47", "parents": [ "0ee39120de4e32b0c33aea4aec1ddccae3bfe072" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Nov 16 01:33:10 2022 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Nov 16 01:33:10 2022 +0000" }, "message": "Add copyright notices to frontend files\n\nChange-Id: I66c94c172cb3ed60c69fe4874a83d3536fb40058\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/760142\nReviewed-by: Matt Hamrick \u003cmjhamrick@google.com\u003e\n" }, { "commit": "0ee39120de4e32b0c33aea4aec1ddccae3bfe072", "tree": "316a02817a5dced408db2096c8cf5a29d0f45fbf", "parents": [ "140a612e05f6a0432a73545a0d717fc757de1615" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Nov 16 01:33:02 2022 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Nov 16 01:33:02 2022 +0000" }, "message": "Update all npm dependencies\n\nIt now works with Node 18 and NPM 8. Previously we had to use Node 16\nbecause of some issues with dependencies.\n\nAlso switched from optimize-css-assets-webpack-plugin to\ncss-minimizer-webpack-plugin since the former recommended doing that for\nwebpack 5 support.\n\nChange-Id: Idb581ec0502a3d7505300f10719412f21b0b8678\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/759942\nReviewed-by: Matt Hamrick \u003cmjhamrick@google.com\u003e\n" }, { "commit": "140a612e05f6a0432a73545a0d717fc757de1615", "tree": "e844e6d8b5595c59ed625f6b16c0082718a46b47", "parents": [ "4f994a2ca5338b5964534001d912330bbd5f6014" ], "author": { "name": "Zachary Stewart", "email": "zstewart@google.com", "time": "Tue Nov 15 22:11:30 2022 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Nov 15 22:11:30 2022 +0000" }, "message": "[fidlbolt] highlight open, closed, ajar\n\nUpdate the syntax highlighting to support the new unknown interaction\nmodifiers (open, closed, ajar).\n\nNote that this will highlight any use of thiese modifiers (e.g. a struct\nfield named open), unlike the vscode syntax which only applies these\nmodifiers to protocols.\n\nBug: 88366\nTest: ran fidlbolt locally and checked highlighting\nChange-Id: I6cadb6814dadbb279ef9a5caa71164682172afa0\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/760147\nReviewed-by: Mitchell Kember \u003cmkember@google.com\u003e\n" }, { "commit": "4f994a2ca5338b5964534001d912330bbd5f6014", "tree": "cc94b09f510f68c8d6af671eeb749553a9c30253", "parents": [ "a6747cdaa4a1a00d0fa1b7b63c7b368106b4bb5c" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Fri Oct 14 19:22:31 2022 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Fri Oct 14 19:22:31 2022 +0000" }, "message": "Add support for LEGACY version\n\nBug: 106549\nChange-Id: I90461e0cbf60064130e4f80534929176ce00b796\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/740608\nReviewed-by: Alex Zaslavsky \u003cazaslavsky@google.com\u003e\n" }, { "commit": "a6747cdaa4a1a00d0fa1b7b63c7b368106b4bb5c", "tree": "2d0f994c6200514d136dad5e95e359b4c2b23e8e", "parents": [ "fe0740532928ed400da7b5340497e7781d1e546f" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Fri Oct 14 18:46:58 2022 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Fri Oct 14 18:46:58 2022 +0000" }, "message": "Allow overriding background selection color\n\nThe Ace editor uses the same color for regular selections and search\nhighlights, which is fairly low contrast in all themes. This CL adds an\ninput to the settings form to override that color.\n\nFixed: 112017\nChange-Id: I1bea0beae7e7ab7f94f5db49463f79061bff1169\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/740607\nReviewed-by: Mukesh Agrawal \u003cquiche@google.com\u003e\n" }, { "commit": "fe0740532928ed400da7b5340497e7781d1e546f", "tree": "e19e70bd117a181bfa8450e5521318132bcce4e3", "parents": [ "92255e5c31429458d02b81c7c822736d74f9a07d" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Aug 11 17:26:18 2022 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Aug 11 17:26:18 2022 +0000" }, "message": "Rename LLCPP tab to C++\n\nThis CL renames the editor tab \"LLCPP\" to \"C++\", and changes the string\nidentifier representing it from \"llcpp\" to \"cpp\". It decodes \"llcpp\"\ninto \"cpp\" on the client (from localStorage) and server (from client).\n\nTest: manually tested loading new client with \"llcpp\" in localStorage\nTest: manually tested old client on LLCPP tab with new server\nBug: 106610\nChange-Id: I788ab913757a8a1ec06826bdebb3b7a4bcdc6649\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/711102\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "92255e5c31429458d02b81c7c822736d74f9a07d", "tree": "b97decf6ea2a43b60e950d397f20a8f454755a1e", "parents": [ "03325c23237fc854ea1b33de04ce259db7def343" ], "author": { "name": "Zachary Stewart", "email": "zstewart@google.com", "time": "Fri May 13 18:14:21 2022 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Fri May 13 18:14:21 2022 +0000" }, "message": "Add LLCPP/Natural Type type_conversions.{h,cc}\n\nAdd support for viewing LLCPP-Natural Types Type Conversion headers and\nimplementation.\n\nChange-Id: I798c39d8709dabe7355f9b13c688e24c9506b28a\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/679007\nReviewed-by: Mitchell Kember \u003cmkember@google.com\u003e\n" }, { "commit": "03325c23237fc854ea1b33de04ce259db7def343", "tree": "e7907fddf6efb07d1c4adff5dcd4b272125c9ccb", "parents": [ "03f45abdfc48ece0d12fa505f10f754b7bb90280" ], "author": { "name": "Zachary Stewart", "email": "zstewart@google.com", "time": "Thu May 12 16:03:40 2022 +0000" }, "committer": { "name": "Zachary Stewart", "email": "zstewart@google.com", "time": "Thu May 12 16:03:40 2022 +0000" }, "message": "Show driver-transport natural types.\n\nUpdate the LLCPP file selection drop-downs to also show\ndriver/natrual_messaging.h and driver/natrual_messaging.cc\n\nChange-Id: I3f652ed2266a1516533ae99fa21e524bf7f4f100\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/678311\nReviewed-by: Mitchell Kember \u003cmkember@google.com\u003e\n" }, { "commit": "03f45abdfc48ece0d12fa505f10f754b7bb90280", "tree": "8c77d7bbec04ab6f643dddcde80572c274fc94aa", "parents": [ "ad217fcfb8fab0627f4fc285d4399a37ae8d10c1" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Apr 06 20:18:22 2022 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Apr 06 20:18:22 2022 +0000" }, "message": "Add support for FIDL versioning\n\nThis CL adds a text field for passing --available flags to fidlc, e.g.\n\"test:7\" of \"fuchsia:HEAD\". It also adds some content about versioning\nin the help tab, and adds a notice about versioning similar to the one\nused for the new syntax last year.\n\nThe \"Version\" text field is empty by default but has \"test:HEAD\" as a\nplaceholder. This works for the default FIDL input (which names the\nlibrary test.fidlbolt). I made it a placeholder rather than default so\nthat it will not cause errors if the user changes the library name, e.g.\nif they type `library fuchsia.io;` then \"test\" no longer exists. Also,\nthe text field is validated by a regex and only ever registers updates\nfrom one valid entry to the next. This avoids getting errors from the\nserver while in the process of typing in that text field.\n\nThis also fixes the way localStorage values are conformed to the\nexpected schema. Id8d6206210f20118df406cc4d03000110af57f62 did this\noriginally but it incorrectly conformed everything based on the active\ninput/output tab rather than the input/output keys in the map.\n\nChange-Id: Idc0afb8fd1d1dde576e360f797f1353c791c7fb4\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/666302\nReviewed-by: Alex Zaslavsky \u003cazaslavsky@google.com\u003e\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "ad217fcfb8fab0627f4fc285d4399a37ae8d10c1", "tree": "31418b755c112f638a7f8799003d081105461b6c", "parents": [ "2441d37331d6c76d3e9ed8f6dab4ba4d8d84f65b" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Mar 23 21:03:13 2022 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Mar 23 21:03:13 2022 +0000" }, "message": "Stop lexing keywords in parser.go\n\nThis CL removes the lexer tokens Keyword and Bool from parser.go to more\nclosely match fidlc, which delays such classification of alphanumeric\nidentifiers until later. This enables fidlbolt to properly parse library\ndeclarations such as `library true;`, which previously did not work.\n\nTest: manually tested\nFixed: 96235\nChange-Id: I4b09e2056d03629a332f46f84772dd88fb699c51\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/661487\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "2441d37331d6c76d3e9ed8f6dab4ba4d8d84f65b", "tree": "e0ce133e61d6c097529063cf6ee0604033c152a7", "parents": [ "a5898e810b31872d6610d18057b5282937fc67d3" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Mar 17 18:30:21 2022 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Mar 17 18:30:21 2022 +0000" }, "message": "Match zircon/vdso/zx/BUILD.gn logic\n\nThis CL restricts compilation of library zx to only include\nzx_common.fidl and rights.fidl, matching zircon/vdso/zx/BUILD.gn.\nPreviously it globbed all *.fidl files, which is only used for the\nfidlc -\u003e kazoo flow, not the fidlc -\u003e fidlgen flow. The latter started\nbreaking on the latest fidlgen deployment because fidlgen_cpp code was\nnot expecting to see JSON IR entries arising from including all the vdso\n*.fidl files, e.g. the PacketUser union.\n\nTest: manually tested the fxbug.dev/95560 repro\nFixed: 95560\nBug: 90838\nChange-Id: Iaa668742ff381dde5c38787fc82b8ebfdd134f51\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/658466\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "a5898e810b31872d6610d18057b5282937fc67d3", "tree": "fd4cab585b725bd614235e66ebe883e298304865", "parents": [ "769a60a6f6bc76eafec99f63d5944e64493a0768" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Feb 16 18:30:47 2022 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Feb 16 18:30:47 2022 +0000" }, "message": "Add fuchsia/sdk/banjo to Dockerfile\n\nThis was missed in Idd863f42bd176551c400b8f179c96612e4145cea.\n\nBug: 72629\nChange-Id: I13ecaaa46911d2a66985a22f3b11233607b4defd\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/646181\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "769a60a6f6bc76eafec99f63d5944e64493a0768", "tree": "0af84ef2f551c8d9c939b3f8b962b2a2c173950a", "parents": [ "46d1eb91edec99d9f4cc6735066d15dd2a8b24cd" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Feb 14 22:20:25 2022 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Feb 14 22:20:25 2022 +0000" }, "message": "Update dropdown for LLCPP\n\nBug: 93781\nChange-Id: Ida6f16fd4c4c8e33826160b8d91bbbf7dad8d741\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/645989\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "46d1eb91edec99d9f4cc6735066d15dd2a8b24cd", "tree": "797a390747f25b6f3dabc9eac288837ce25223e6", "parents": [ "f1fd532fc879330d753fa4f051fab40ae0f2a976" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Feb 14 22:17:44 2022 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Feb 14 22:17:44 2022 +0000" }, "message": "Look for fidl libraries in fuchsia/sdk/banjo\n\nBug: 72629\nChange-Id: Idd863f42bd176551c400b8f179c96612e4145cea\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/646082\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "f1fd532fc879330d753fa4f051fab40ae0f2a976", "tree": "d53135f9c3db3363a298699f4a5ad6af56cad727", "parents": [ "48fa9b5619854dcf859f9d8e4f5953bc99373bbe" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Nov 08 22:02:49 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Nov 08 22:02:49 2021 +0000" }, "message": "Update rustfmt prebuilt directory in Makefile\n\nForgot to do this in I7d7e2e222e1b9180f3b34e05fa83f402294f6a0d.\n\nAlso removing the oudated Go version in the README. The correct version\nis specified in backend/go.mod.\n\nChange-Id: Ie279dfbb219b989f9fecefdb3c3826e08528d718\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/603448\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "48fa9b5619854dcf859f9d8e4f5953bc99373bbe", "tree": "63f346c3ec726b39a21265ce4fc38b169693936e", "parents": [ "a8104506021c493969f0d168dc6ff63e2cfbd7c0" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Oct 18 18:15:03 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Oct 18 18:15:03 2021 +0000" }, "message": "Replace regexes with participle parser\n\nThis CL replaces the regexes to find the library name and imports with a\nproper parser based on the official FIDL grammar. It uses the participle\nlibrary to generate the parser.\n\nTest: manually checked declaring new file alongside SDK library\nTest: manually checked importing SDK libraries\nTest: manually built and run docker container to check new go dependencies\nFixed: 86590\nChange-Id: I0192909b48b5e74b3c5f16746fa3705ca23eebfc\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/594784\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "a8104506021c493969f0d168dc6ff63e2cfbd7c0", "tree": "a7f3f5588fd94070bf419ed62c24b7461388a5ec", "parents": [ "e1f7d69c966109ce3c61b5b3b0a07feb45da40fa" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Oct 14 23:19:21 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Oct 14 23:19:21 2021 +0000" }, "message": "Fix libraryRegexp to allow attributes\n\nBug: 86590\nChange-Id: I7623b363125384f1bb3f2bd1eb2e30a2c8b261f1\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/593801\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "e1f7d69c966109ce3c61b5b3b0a07feb45da40fa", "tree": "dd231615ef2cd9347737d2c7162c22c32d473b62", "parents": [ "b82cff256a0627a9e538895bfa40b8c1b74336a6" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Sep 30 19:24:21 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Sep 30 19:24:21 2021 +0000" }, "message": "Update for fidlgen_llcpp flags change\n\nThis CL fixes fidlbolt\u0027s invocation of fidlgen_llcpp now that the flags\nhave changed in I6ad1235d3259e3874293bb4a66113acd02c49e9f to just pass\n--root instead of --header and --source. Since the paths it use include\nthe library name, this required some refactoring to expose the root\nlibrary name from the analysis.\n\nChange-Id: I0f7f1abdd605a388ed1491c94a111b502426824f\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/587923\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\nReviewed-by: Ian McKellar \u003cianloic@google.com\u003e\n" }, { "commit": "b82cff256a0627a9e538895bfa40b8c1b74336a6", "tree": "0ba36899e5afecfcc17ab1cbbe8142b0cce1d20f", "parents": [ "caf6e061b6440d94def74af1f6f6f99bed921528" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Sep 30 19:09:05 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Sep 30 19:09:05 2021 +0000" }, "message": "Conform localStorage form values after decoding\n\nThis CL makes the fidlbolt client throw out any invalid form values that\nget populated from localStorage. This means API breakage for form values\nonly imposes a refresh on users, rather than requiring them to find and\nclick the \"Reset all data\" button.\n\nChange-Id: Id8d6206210f20118df406cc4d03000110af57f62\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/587933\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "caf6e061b6440d94def74af1f6f6f99bed921528", "tree": "d6a5d9c67c7f07d30261d7657318eb45d5d56b6a", "parents": [ "e1cb1c1f26a46ea643d0371cd86fb0e896943805" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Sep 30 00:14:04 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Sep 30 00:14:04 2021 +0000" }, "message": "Handle library match failure up front in analyze()\n\nThis CL makes analyze() less confusing. It took me a very long time\nreading it to remember why it handled the case of failing to parse the\nlibrary declaration. So I moved it to the top and added a comment.\n\nChange-Id: I8ce78559f18a08edd1705535f96cead28fd1a03f\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/587921\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "e1cb1c1f26a46ea643d0371cd86fb0e896943805", "tree": "0994a24f1cc037b30bdae676f0d7de74ab1ba39e", "parents": [ "3c9b6adec01808bd015693da9887c7c701268e6f" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Sep 30 00:13:50 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Sep 30 00:13:50 2021 +0000" }, "message": "Remove checks for hyphenated library names\n\nThis CL removes checks for directories whose names are FIDL libraries\nwith \".\" replaced by \"-\". Those used to exist in zircon/system/fidl, but\nno longer (that directory still exists but it only has build rules, no\nFIDL files).\n\nChange-Id: I9634d3c1e23844fd6bfab4d9a11925a2a382c844\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/587298\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "3c9b6adec01808bd015693da9887c7c701268e6f", "tree": "be659da79ab032a49fb48e4de098f4d97508afe0", "parents": [ "eeb16de00254f38eeaa00cbfcee08490623cd54f" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Sep 30 00:13:40 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Sep 30 00:13:40 2021 +0000" }, "message": "Remove `deprecated_syntax;` from library regex\n\nThis is no longer neede post syntax migration.\n\nThis reverts I21dcabf90e3cbaf3b5b829919c7d42e5cddcd134.\n\nBug: 70247\nChange-Id: I3de0a37f0875bcbbaa148711e5dd5867af05c2fc\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/587299\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "eeb16de00254f38eeaa00cbfcee08490623cd54f", "tree": "caea41fbf551de2c014b43c8ba010f0f60e040ef", "parents": [ "42fecee0922da5dd1222a668ac9f436ae73d890e" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Sep 27 22:24:04 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Sep 27 22:24:04 2021 +0000" }, "message": "Fix directory logic in prepare_deployment.sh\n\nChange-Id: I2c9e384b5552ea94f275f38c6a4b1be59c6aa9c2\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/586481\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "42fecee0922da5dd1222a668ac9f436ae73d890e", "tree": "a23eea996b90deff2e9965d6fd2c89e0a17e99c0", "parents": [ "749b6dd2206df5282ec106f6a477db87f95f692c" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Sep 22 06:08:32 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Sep 22 06:08:32 2021 +0000" }, "message": "Use out/fidlbolt build directory in prepare_deployment.sh\n\nThis CL makes prepare_deployment.sh run \u0027fx set core.x64 --release\u0027 in a\nseparate Fuchsia build directory, out/fidlbolt. This makes it easier to\ndeploy without interfering with other work, and eliminates the chance of\naccidentally deploying the wrong build (e.g. a debug build).\n\nChange-Id: Ifa1474db8d954aafb22f5a59737d2a13f7afec88\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/584263\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "749b6dd2206df5282ec106f6a477db87f95f692c", "tree": "8399719a468a47279e0e7367b6cc17724345cede", "parents": [ "e2aafb3e9d0d2948ee3043bc4340f7e06986886d" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Sep 22 05:29:45 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Sep 22 05:29:45 2021 +0000" }, "message": "Upgrade from go 1.13 to 1.17\n\nThe only code change is in system_test.go for the new build tag syntax:\nhttps://golang.org/doc/go1.17#build-lines.\n\nTest: locally built docker image and manually tested container\nChange-Id: I1821b3ecc92a5ab4bba9e86f90217367a73f5ecd\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/584265\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "e2aafb3e9d0d2948ee3043bc4340f7e06986886d", "tree": "bc1f8818e2247c6d139dc09dbb80cc45d100c750", "parents": [ "33ff40d3443c9809e67c81a91f4061b42615cb0b" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Sep 22 05:29:36 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Sep 22 05:29:36 2021 +0000" }, "message": "Remove all references to topaz\n\nSince fxrev.dev/445015, fidlgen_dart has been in fuchsia.git rather than\nin topaz.git, so there is no need for fidlbolt to keep track of the\ncommit hash for topaz.\n\nBackward compatibility: if an old client gets the deployment info from\nthe new server, it will fail to decode due to the missing topaz field,\nand show \"(No deployment information)\" in the help window. I manually\nchecked this.\n\nChange-Id: Ie9f3c209f9879d19fe0cc9deb7380c647bc47760\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/584264\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "33ff40d3443c9809e67c81a91f4061b42615cb0b", "tree": "eedf19ebabae2134f5b2f739f8dc9cf26f70d136", "parents": [ "4a913a5b2cffefced0a5fef984bd4d162d13ed0d" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Sep 22 01:19:26 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Sep 22 01:19:26 2021 +0000" }, "message": "Handle relative and absolute .fx-build-dir paths in `make run`\n\nThis CL ensures that `make run` works correctly whether the path in\n$FUCHSIA_DIR/.fx-build-dir is relative or absolute. The logic in\nFuchsia\u0027s tools/devshell/lib/vars.sh indicates it can be either, and\nthis has been my experience.\n\nTest: manually tested `make run` in both cases\nChange-Id: I1232ab9e63f2c350f7fbd52a058d8a1e8617b45f\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/584221\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "4a913a5b2cffefced0a5fef984bd4d162d13ed0d", "tree": "51a85f71350edac86fe71b372079eb9645f9f9d6", "parents": [ "7853f1684d19c5fe15f30823dcde8a010e97bd6e" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Sep 09 01:00:10 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Sep 09 01:00:10 2021 +0000" }, "message": "Clean up after syntax migration\n\nThis CL reverts the auto-convert feature that was temporarily added in\nI4e4f33f177860be8db7a139b9d81192e0bca7d1e for the new FIDL syntax, since\nthis no longer works as of the cleanup in fxrev.dev/574026. It leaves\nthe \"news\" abstraction since we can reuse this in the future.\n\nChange-Id: I27b7c54363a3864693cbdb8143bc4588b25553f3\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/579181\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "7853f1684d19c5fe15f30823dcde8a010e97bd6e", "tree": "61fbfcec3de95fd6cbfe44f12e8198f275e811f5", "parents": [ "968e7b7791240b9bd3182d6ed77d9a6f21c4b4b4" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Sep 09 00:25:17 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Sep 09 00:25:17 2021 +0000" }, "message": "Update rustfmt path\n\nThis CL updates the rustfmt path used in prepare_deployment.sh based on\nhttps://groups.google.com/a/fuchsia.dev/g/rust-users/c/nNmnQtph1e8/m/5WXVTkOWBgAJ.\n\nChange-Id: Ib990b4d2761936f16c244efdd4f0e6f16c79a9a6\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/578624\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "968e7b7791240b9bd3182d6ed77d9a6f21c4b4b4", "tree": "16bbc12daaffd7af5977c10b8e7cea8b393f792a", "parents": [ "40401c47be7b5ce249c273ef0a82de0e10bf0f7a" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Fri Jul 30 23:44:37 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Fri Jul 30 23:44:37 2021 +0000" }, "message": "Fix typo \"coments\" -\u003e \"comments\"\n\nChange-Id: I516f726cacff62c3d837f5b6ee55e804d5091efc\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/562886\nReviewed-by: Misha Gridnev \u003cgridman@google.com\u003e\n" }, { "commit": "40401c47be7b5ce249c273ef0a82de0e10bf0f7a", "tree": "41d02dd2c556581cd9111b85597cc553ef902fb7", "parents": [ "97ec10a3d05f5803d0a55153760d32516bd3a8ac" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Fri Jul 23 03:59:25 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Fri Jul 23 03:59:25 2021 +0000" }, "message": "Highlight FIDL keyword \"service\"\n\nChange-Id: I28257987736efd846d80bdc2c901fcc792f69858\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/559061\nReviewed-by: Alex Zaslavsky \u003cazaslavsky@google.com\u003e\n" }, { "commit": "97ec10a3d05f5803d0a55153760d32516bd3a8ac", "tree": "f225e9a751364e97be08bf2dc1c1a853b6a37a51", "parents": [ "154d1867cb231a9b4eb892f02f6f073960d85686" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Jul 21 17:51:46 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Jul 21 17:51:46 2021 +0000" }, "message": "Support new FIDL syntax\n\nThis CL makes fidlbolt pass `--experimental allow_new_syntax` to allow\nthe new syntax. It also presents a notice/alert at the top of the page\nabout the new syntax (which can be dismissed), and offers to\nautomatically convert FIDL to the new syntax if it detects the user is\nusing the old syntax.\n\nChange-Id: I4e4f33f177860be8db7a139b9d81192e0bca7d1e\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/557964\nReviewed-by: Yifei Teng \u003cyifeit@google.com\u003e\n" }, { "commit": "154d1867cb231a9b4eb892f02f6f073960d85686", "tree": "39d9d860b9b1cf080d77affbd271d4f5e800819f", "parents": [ "9f3b157b8b1797391455db13a8f5dee867b2b6e3" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Jul 21 17:51:39 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Jul 21 17:51:39 2021 +0000" }, "message": "Refactor CSS classes a bit\n\n* Rename output-options to editor-options (will have input ones later).\n* Refactor common button properties into a button class.\n\nChange-Id: I2d44818eb878630f98d7229965876c1d158c78db\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/557963\nReviewed-by: Mitchell Kember \u003cmkember@google.com\u003e\n" }, { "commit": "9f3b157b8b1797391455db13a8f5dee867b2b6e3", "tree": "f538e00e9396cfe94e1acfae61b5421b110bb642", "parents": [ "5ebec5e20390ea7460a99a7559d03ae594b07078" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Jul 19 19:04:14 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Jul 19 19:04:14 2021 +0000" }, "message": "Update syntax highlighting for new FIDL syntax\n\nThe syntax highlighting rules are based on simple regexes, so not much\nchange was needed. I used \"support.constant\" for attributes because it\nwas the only one that looked decent in a few different color schemes.\n\nChange-Id: I2574211b978a03fdcdae41d0780b76b68f14982f\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/557111\nReviewed-by: Alex Zaslavsky \u003cazaslavsky@google.com\u003e\n" }, { "commit": "5ebec5e20390ea7460a99a7559d03ae594b07078", "tree": "8771589ee5f352e4dec7c45195693d3440a60f12", "parents": [ "c4f91ac019b73c71d1bd63b21586c33124391d1f" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Jun 21 22:08:27 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Jun 21 22:08:27 2021 +0000" }, "message": "Fix FIDL library parsing to allow deprecated_syntax\n\nAs of Ifb06be9cd1eaab780f59f6398095b05ee1e75958, all FIDL files in tree\nhave `deprecated_syntax;` at the top, used for the transition to the new\nsyntax. This broke fidlbolt\u0027s regex parsing, so importing SDK libraries\nstopped working. This CL fixes that.\n\nBug: 70247\nTest: manually tried `deprecated_syntax; library fuchsia.io;`\nChange-Id: I21dcabf90e3cbaf3b5b829919c7d42e5cddcd134\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/545885\nReviewed-by: Felix Zhu \u003cfcz@google.com\u003e\n" }, { "commit": "c4f91ac019b73c71d1bd63b21586c33124391d1f", "tree": "c887109442c908753f97aa9c0a56fed28a21985c", "parents": [ "f6041695bdfb76873ef8734f7ee89b4d275c20d0" ], "author": { "name": "Felix Zhu", "email": "fcz@google.com", "time": "Tue Jun 15 14:45:47 2021 +0000" }, "committer": { "name": "Felix Zhu", "email": "fcz@google.com", "time": "Tue Jun 15 14:45:47 2021 +0000" }, "message": "Add old_syntax_only setting\n\nThis keeps the fidlbolt fidlc invocation in sync with the one\nused to build in-tree, and will be necessary when SDK FIDL files\nget updated to use `deprecated_syntax;`\n\nChange-Id: Iae088d6acc22506a3f68557724111985bf0341e7\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/542866\nReviewed-by: Mitchell Kember \u003cmkember@google.com\u003e\n" }, { "commit": "f6041695bdfb76873ef8734f7ee89b4d275c20d0", "tree": "0d6d3fb5c612152347cd349b0fe6e1c2b0fbb07f", "parents": [ "b119ebc057b457eb284b370f3f865d6013480762" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon May 24 18:48:31 2021 +0000" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon May 24 18:48:31 2021 +0000" }, "message": "Rename C bindings flags\n\nThis CL updates the C bindings flags based on changes to fidlc in\nI89cebe6b5ce6a16a381afde294cf7636010038f8. All the C bindings flags now\nstart with \"--deprecated-fuchsia-only-\".\n\nChange-Id: I26ac2281971b9c8a6d745685a9d81013a585bf80\nReviewed-on: https://fuchsia-review.googlesource.com/c/fidlbolt/+/534241\nReviewed-by: Felix Zhu \u003cfcz@google.com\u003e\n" }, { "commit": "b119ebc057b457eb284b370f3f865d6013480762", "tree": "bb81b56e7f47d4784a78076ac5e74a4b3a5f1056", "parents": [ "0c5bc310b352d6bc23e5ce94fd41b3a6baa96427" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Feb 22 08:34:54 2021 -0800" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Feb 22 08:34:54 2021 -0800" }, "message": "Add \"Test base\" to the LLCPP tab\n\nThis CL adds support for fidlgen_llcpp\u0027s newly added -test-base\n(fidlbolt was 500ing before because the new flag is required). This also\nchanges Dart\u0027s \"test\" key to use the \"Test base\" label in the UI rather\nthan \"Test\", to match LLCPP.\n\nChange-Id: If737bfbf53146c272cbd028a0591c3b7c78efa3c\n" }, { "commit": "0c5bc310b352d6bc23e5ce94fd41b3a6baa96427", "tree": "b7bf8abd9aec8bfe8eb176bde20e1b2037899489", "parents": [ "4a7acb22bf2ea3e6b4aae099997a662b33fa3325" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Feb 22 08:33:21 2021 -0800" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Feb 22 08:33:40 2021 -0800" }, "message": "Use clang-format for HLCPP and LLCPP\n\nThis CL makes fidlbolt use clang-format, following the same pattern as\nrustfmt. This involves copying it from the prebuilt directory, passing\nit to fidlgen, and listing it in fidlbolt_deployment.json.\n\nChange-Id: Ia7a9a7199396b7a8d81c23ba77f053fc9e1d2894\n" }, { "commit": "4a7acb22bf2ea3e6b4aae099997a662b33fa3325", "tree": "b157460701154d4eecf2bc8182152d4bbd26c6bf", "parents": [ "f877a1fc8f1237b1bb569f83e1c3c4b225bc1df3" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Feb 22 08:27:06 2021 -0800" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Feb 22 08:27:06 2021 -0800" }, "message": "Minor fixes in Makefile and prepare_deployment.sh\n\n* Remove $(build_dir).zircon now that build unification is complete.\n\n* Fix prepare_deployment.sh, now that `fx build` fails if the working\n directory is not inside FUCHSIA_DIR.\n\n* Add a missing double quote in `make help`.\n\nChange-Id: I325d6773dba687c587164a7f4e04a871341c8327\n" }, { "commit": "f877a1fc8f1237b1bb569f83e1c3c4b225bc1df3", "tree": "af576033eff2d54b0c7153b17ee0a2f9861e8dea", "parents": [ "554295acdd3a02009e85f18f651dc8d7eed50407" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Oct 15 11:25:33 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Oct 15 11:25:33 2020 -0700" }, "message": "Highlight \"reserved\" keyword\n\nChange-Id: I4a48a228d305f63d8770fb9222d74f9843bb2d8e\n" }, { "commit": "554295acdd3a02009e85f18f651dc8d7eed50407", "tree": "87e4723bebeceaa27a0d987a99341540dc12dfbd", "parents": [ "6b9199aecaec32a2fb348e55bbadaef706039df3", "7f6da5d0dbf1931bbf37b8733e0a71ba78acb008" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Oct 06 16:44:10 2020 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Oct 06 16:44:10 2020 +0000" }, "message": "Merge \"Show warning annotations and add unit tests\"" }, { "commit": "7f6da5d0dbf1931bbf37b8733e0a71ba78acb008", "tree": "2f873900f87160039398e461ded4df9ad58bf5d4", "parents": [ "e4330b0caff21a7bdac8390f268873bf212f55ed" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Oct 05 17:14:49 2020 -0400" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Oct 06 09:43:15 2020 -0700" }, "message": "Show warning annotations and add unit tests\n\nThis CL refactors system.go for better modularity and adds unit tests in\nsystem_test.go. Further CLs will test more of the backend. In addition:\n\n* FIDL input now shows warning annotations.\n\n* FIDL input now shows info annotations on imports all the time (before\n it did not for FIDL-\u003eFIDL formatting/linting).\n\nChange-Id: Ib9a359aa59d4e03711648d5626268c49a34ee865\n" }, { "commit": "6b9199aecaec32a2fb348e55bbadaef706039df3", "tree": "776eff2aa37cbe9ec1e19c309805e0595ed1721d", "parents": [ "e4330b0caff21a7bdac8390f268873bf212f55ed" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Oct 05 15:04:44 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Oct 05 15:05:32 2020 -0700" }, "message": "Highlight keywords \"strict\", \"flexible\", and \"resource\"\n\nChange-Id: I3dddc31ae977954a76e09da018880d5d704ea21c\n" }, { "commit": "e4330b0caff21a7bdac8390f268873bf212f55ed", "tree": "15ae23df9b1c32885e3f392cd4d237973780d442", "parents": [ "338b289da742c9d043da6993e506384d67c22cf6" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Sep 28 12:15:18 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Sep 28 12:15:18 2020 -0700" }, "message": "Fix prepare_deployment.sh build command\n\n`fx build zircon/tools` no longer works.\n\nChange-Id: Ie86c8cdbd963fef8cb80d7b9aa4162daac7ec1a9\n" }, { "commit": "338b289da742c9d043da6993e506384d67c22cf6", "tree": "dfb039a9ad2a2ca804cd1f18bf99e0549844a381", "parents": [ "51288d7fe2984527ba86e969c45b89ad20531824", "1b896081dfb49a577cadcbd730469f01c0825d03" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Sep 16 13:15:32 2020 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Sep 16 13:15:32 2020 +0000" }, "message": "Merge \"Fix Ctrl+Enter bug for VS Code bindings\"" }, { "commit": "1b896081dfb49a577cadcbd730469f01c0825d03", "tree": "5fbbe21cf26872fe5748e3447b2ff906b008f543", "parents": [ "71932baccf3ba62aaba9608741adbe50fe2729df" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Sep 15 14:15:38 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Sep 15 14:15:38 2020 -0700" }, "message": "Fix Ctrl+Enter bug for VS Code bindings\n\nThe Ctrl+Enter shortcut (Cmd+Enter on macOS) re-evaluates fidlbolt,\nallowing the user to do so immediately rather than waiting for the 500ms\nidle delay. The VS Code bindings have a mapping for Ctrl/Cmd+Enter\ncalled addLineAfter, which was also getting triggered. This CL prevents\nthat by calling stopPropagation() in the event handler.\n\nChange-Id: Ieb1131e783836a3790e99e2bbefe5bccbc5fc339\n" }, { "commit": "51288d7fe2984527ba86e969c45b89ad20531824", "tree": "f555fc07bd19e8dd69f9b81d148c5683b3a067bc", "parents": [ "71932baccf3ba62aaba9608741adbe50fe2729df" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Sep 15 14:12:45 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Sep 15 14:12:45 2020 -0700" }, "message": "Bump Ace from 1.4.8 to 1.4.12\n\nThis includes the following changes\n\n2020.07.06 Version 1.4.12\n* removed unused es5-shim\n* imporved ruby and vbscript highlighting and folding\n* workaround for double space being converted to dot on mobile keyboards\n\n2020.04.15 Version 1.4.10\n* added workaround for chrome bug causing memory leak after calling editor.destroy\n* added code folding support for vbscript mode\n\n2020.04.01 Version 1.4.9\n* added option to disable autoindent\n* added new language modes\n* fixed backspace not working with some mobile keyboards\n\n(Taken from https://github.com/ajaxorg/ace/blob/master/ChangeLog.txt)\n\nChange-Id: I3af9fc22f82a236f572d24e6c651d5fe4bee4996\n" }, { "commit": "71932baccf3ba62aaba9608741adbe50fe2729df", "tree": "115709507792cc0158af66d560e8f7067585765b", "parents": [ "56ff29434ff7a67767efe86e47b6499206b18098" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Sep 10 16:10:42 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Fri Sep 11 10:40:56 2020 -0700" }, "message": "Only expose program failures for exit status 1\n\nThis CL changes the program.run function to return `(response, error)`\ninstead of just `response`. Previously, all failures would be rolled\ninto an `Ok: false` response and shown to the user. Now, it only does so\nfor exit status 1, and otherwise returns an error which bubbles up to a\n500 Internal Server Error, with the `error` object logged on the server.\n\nRationale: we want to show legitimate failures to the user (e.g. fidlc\nwill fail if its input has a syntax error), but we do *not* want to\nexpose information the OS prints when programs crash. We use the exit\nstatus as a proxy for this. For example, a segfault should cause the\nprogram to exit with status 139, not 1.\n\nThis also makes program.run return stdout in the success case and stderr\nin the failure (exit status 1) case, rather than always combining them\nas before. This is a further measure to avoid leaking details that\nshould not be shown to the user. It also allows the logged message for\nexit statuses besides 0 and 1 to show stdout/stderr separately.\n\nChange-Id: I19173e66d37ead6989a7b45ab699976547f97267\n" }, { "commit": "56ff29434ff7a67767efe86e47b6499206b18098", "tree": "fc0b541f46ef44d5ab87d511efcc334db210640c", "parents": [ "d6de62a851d7817db760c18b00c5e9b102804434" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Sep 10 15:00:23 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Fri Sep 11 10:09:12 2020 -0700" }, "message": "Refactor backend code\n\nThis CL refactors the Go backend:\n\n* Use lowercase (unexported) identifiers for types and functions. The\n capital identifiers are a relic from when the backend was split into a\n library and binary package.\n\n* Rename library.go to analyze.go, and move FIDL error parsing code to\n analyze.go. The purpose of analyze.go is analyzing FIDL input/output.\n\nThis CL also updates the rustfmt prebuilt directory in the Makefile.\nThis was done in I7d7e2e222e1b9180f3b34e05fa83f402294f6a0d for\nprepare_deployment.sh, but it missed the Makefile (local development).\n\nChange-Id: I2f1e6e85830a3e771661288704790c8c9933dd05\n" }, { "commit": "d6de62a851d7817db760c18b00c5e9b102804434", "tree": "5e7b8fd90caead8fad37619db3bcc50827194644", "parents": [ "921a682d223185f3ab2f2b50fd5bc680316a3973" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Aug 04 13:46:37 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Aug 04 13:46:37 2020 -0700" }, "message": "Update rustfmt prebuilt directory\n\nThe prebuilt rustfmt binary has been moved:\n\n prebuilt/third_party/{rust \u003d\u003e rust_tools}/linux-x64/bin\n\n(See https://fuchsia-review.googlesource.com/c/fuchsia/+/411238).\n\nThis CL updates prepare_deployment.sh to get it from there.\n\nChange-Id: I7d7e2e222e1b9180f3b34e05fa83f402294f6a0d\n" }, { "commit": "921a682d223185f3ab2f2b50fd5bc680316a3973", "tree": "376aaf1124b76e705cd1407163c32435380c399c", "parents": [ "76539abe4bee561e174b5ff3ef89bd2ec4b5a321", "a79c78d1e3d34296966fa63b0fa24d80af8021ca" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Jun 01 18:15:20 2020 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Jun 01 18:15:20 2020 +0000" }, "message": "Merge \"Revert server.go changes from \"Fix C output and .dockerignore\"\"" }, { "commit": "a79c78d1e3d34296966fa63b0fa24d80af8021ca", "tree": "547616aab6f4ebce85c1edf842ec90a852985e97", "parents": [ "272c2291301101da197c5ae1428264956e3df9d1" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Jun 01 10:28:03 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Jun 01 10:30:01 2020 -0700" }, "message": "Revert server.go changes from \"Fix C output and .dockerignore\"\n\nThis partially reverts commit 272c2291301101da197c5ae1428264956e3df9d1.\nIt only reverts the change to use --fuchsia-only-* flags, not the\n.dockerignore fixes.\n\nThe --fuchsia-only-* change was reverted in fuchsia.git due to breaking\nFlutter https://fuchsia-review.googlesource.com/c/fuchsia/+/393333.\n\nChange-Id: Ie9fcfbe46e7c2c28ca78df85828c9a7f8335faa2\n" }, { "commit": "76539abe4bee561e174b5ff3ef89bd2ec4b5a321", "tree": "6ec1c51449962cc93c9ae7be8dfcd3fd52006301", "parents": [ "272c2291301101da197c5ae1428264956e3df9d1" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Jun 01 10:21:50 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Jun 01 10:21:50 2020 -0700" }, "message": "Stop using zircon/system/fidl\n\nBuild unification has moved all libraries from zircon/system/fidl into\nsdk/fidl. It is no longer necessary to copy from that directory when\npreparing a deployment.\n\nChange-Id: I8989b830d1cd136876841271af0f8f7efdeb42b5\n" }, { "commit": "272c2291301101da197c5ae1428264956e3df9d1", "tree": "de0781fdb169343c59cfe1665cf244b6647bcd43", "parents": [ "cd5d4903938c44296564bafac57a9657bbd0506c" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue May 26 12:19:25 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue May 26 12:19:25 2020 -0700" }, "message": "Fix C output and .dockerignore\n\n* Fix the arguments to fidlc for the simple C header, client and server.\n See https://fuchsia-review.googlesource.com/c/fuchsia/+/391775\n\n* Fix the .dockerignore file. It was using the wrong syntax so it was\n not actually ignoring files, and would upload more than needed.\n\nChange-Id: I75979a72a5dde355699babd40141655747fec526\n" }, { "commit": "cd5d4903938c44296564bafac57a9657bbd0506c", "tree": "d58bffd7ae4b58118b50b4864f467f36d90bc102", "parents": [ "731367a997b16c9718027c781ef0fb2ab6d82ec5" ], "author": { "name": "Peter Johnston", "email": "peterjohnston@google.com", "time": "Tue Apr 28 15:32:58 2020 -0400" }, "committer": { "name": "Peter Johnston", "email": "peterjohnston@google.com", "time": "Tue Apr 28 19:49:30 2020 +0000" }, "message": "Add syntax highlighting to error output\n\nThe color is in this format:\n \u003cbold\u003efidlbolt.fidl:4:15 \u003c/bold\u003e\u003cinvalid\u003eerror:\u003c/invalid\u003e\n \u003cbold\u003e error message\u003c/bold\u003e\n error span\n \u003cbold\u003e\u003ckeyword\u003e^~~~~~~~~~\u003c/keyword\u003e\u003cbold\u003e\n\nWhere `invalid` and `keyword` are styles defined by Ace editor themes.\n\nChange-Id: I26ebf699631b76773cbf24bb2b21e2196c15c8e6\n" }, { "commit": "731367a997b16c9718027c781ef0fb2ab6d82ec5", "tree": "fca69b46dc1aea619b566b964a5459904122fe29", "parents": [ "206cc28cdfbd8007cd42fb8aefcb63dbad133266" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Apr 27 17:31:06 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Apr 27 17:54:04 2020 -0700" }, "message": "Import zx from zircon/vdso, and various other fixes\n\nThis CL enables `using zx` to work in fidlbolt. The zx library used to\nbe a fidlc built-in, but as of Ib026655c3e8133bb14c92d0a5a68e730e26b746d\nit is an ordinary library. This means fidlbolt needs to search in\n//zircon/vdso so find its .fidl files.\n\nIn addition, this CL:\n\n* Restructures the deployment/ directory to put all FIDL libraries under\n deployment/fuchsia/. This fixes the info tooltips which say where the\n library was found (library.go searches for \"/fuchsia/\" in the path).\n\n* Sources fx-env.sh in prepare_deployment.sh so that users with multiple\n checkouts can simply run `FUCHSIA_DIR\u003d... ./prepare_deployment.sh`.\n\n* Changes the Makefile to use lowercase variable names, to distinguish\n them from user-configurable env variables which are in uppercase.\n\n* Improves the error message when the fidlbolt_deployment.json file\n cannot be read or fails to parse.\n\n* Updates the README to recommend installing npm instead of nodejs (both\n are required, and the former gets you both).\n\n* Changes the frontend to use \u003chtml lang\u003d\"en\"\u003e.\n\nChange-Id: I0ff7ebba77089e483a506e522f7fc5ba1b482e91\n" }, { "commit": "206cc28cdfbd8007cd42fb8aefcb63dbad133266", "tree": "2e449d1e67e65379dd82634a60a6a0168acc463e", "parents": [ "a28a3acebaabb15365671a77f0834ce088a2f1eb" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Apr 20 09:05:07 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Apr 20 09:05:07 2020 -0700" }, "message": "Use ZIRCON_TOOLS_DIR in prepare_deployment.sh\n\nI forgot to change this in I5b200e9983a0142841faee100e58f8553eaab5eb. I\nhad at first been using `fx ninja` for a more targeted build, but went\nback to `fx build zircon/tools` because it didn\u0027t seem to pick up all\nchanges. With that, it is simpler to use the ZIRCON_TOOLS_DIR directory.\n\nChange-Id: I71170353a075896d551badf7709fa6695d8d816a\n" }, { "commit": "a28a3acebaabb15365671a77f0834ce088a2f1eb", "tree": "f47aaec3b9240d1d4bdcb0a9bbf9c3962179b248", "parents": [ "23c3704553a111673b2b34e8fa8790ff27b61230" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Apr 16 17:06:05 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Apr 16 17:59:38 2020 -0700" }, "message": "Simplify deployment process\n\nThis CL simplifies the fidlbolt deployment process. It is now 3 steps:\n\n1. Get repositories (fuchsia, topaz) in the state you want them\n2. Run ./prepare_deployment.sh\n3. Build docker image or submit to gcloud\n\nThe prepare_deployment.sh script takes care of building all the FIDL\nbinaries. It emits warnings if there are uncommitted changes or if the\ncommit has not been published to a remote.\n\nThis CL also standardizes on the name \"deployment\" to refer to the set\nof resources copied in by prepare_deployment.sh. It used to be\n\"support\", and before that \"fuchsia\". The renamings:\n\n ./support -\u003e ./deployment\n copy_support_files.sh -\u003e prepare_deployment.sh\n watch.sh -s -\u003e watch.sh -d\n make run SUPPORT\u003d1 -\u003e make run DEPLOYMENT\u003d1\n\nThis should be the last renaming.\n\nChange-Id: I5b200e9983a0142841faee100e58f8553eaab5eb\n" }, { "commit": "23c3704553a111673b2b34e8fa8790ff27b61230", "tree": "37f0bdb81f48b6e59123fbbf4b944b6d2ef85087", "parents": [ "f9f5c3a5564d89c9dbab2ddd1e1c5b2726775d64" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Apr 15 18:18:46 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Apr 15 22:34:21 2020 -0700" }, "message": "Display deployment information dynamically\n\nThis CL introduces the concept of a \"fidlbolt deployment\" as a set of\ngit hashes and version strings that identify all source code responsible\nfor processing a fidlbolt request. Currently, this information includes\nhashes for fidlbolt, fuchsia, and topaz, and a version for rustfmt.\n\nThe script copy_support_files.sh now writes fidlbolt_deployment.json.\nThe server passes this information with every response, and the frontend\nuses it to show links and timestamps at the bottom of the Help window.\nIt is sent with every response rather than just queried once because\nthere is no reason to assume users will refresh soon after a deployment.\n\nThis CL also renames the fuchsia/ directory to support/ (and similarly\ncopy_fuchsia_files.sh to copy_support_files.sh) since this directory is\nmore general with the inclusion of fidlbolt_deployment.json and rustfmt.\n\nOther small changes:\n\n* Add CSS styling for links.\n\n* Use FORCE_COLOR in watch.sh to get npm color output.\n\n* Link to Monorail for bug reports instead of my email.\n\nChange-Id: I5af577522c6b5ef04119913b2781bd7963edfc17\n" }, { "commit": "f9f5c3a5564d89c9dbab2ddd1e1c5b2726775d64", "tree": "079b9abfcf68427d5144e8cdaea9e311f7ce761e", "parents": [ "a74ea8c2ecb7f13a78c5af31ef213998f079a84d" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Apr 14 16:59:46 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Tue Apr 14 17:09:47 2020 -0700" }, "message": "Add watch.sh and improve Fuchsia copy workflow\n\nThis CL:\n\n* Adds watch.sh, an all-in-one script to make hacking on fidlbolt\n easier. It watches for file changes in the frontend and backend,\n automatically rebuilding and restarting the server as necessary.\n\n* Improves copy_fuchsia_files.sh, adding a help message and making use\n of tools/devshell/lib/vars.sh to set environment variables.\n\n* Changes the behavior of `make run COPY\u003d1` so that it no longer runs\n copy_fuchsia_files.sh for you. I changed this because I often found\n myself wanting to copy once after getting my fuchsia tree in the\n desired state (for a deployment), and not copy again after that.\n\n* Updates the README to account for these changes.\n\nChange-Id: Ie59b819d2b8b0ff500f4c2632bc23044607da911\n" }, { "commit": "a74ea8c2ecb7f13a78c5af31ef213998f079a84d", "tree": "587537a537ff3d41945cbb7475ea3ce6de142ec1", "parents": [ "6f3a32380c95fbb42790e1fe9fda29cb5836a0f7" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Wed Apr 08 14:43:38 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Apr 09 19:14:05 2020 -0700" }, "message": "Pass rustfmt to fidlgen_rust\n\nThis CL adds support for rustfmt, so that FIDL-\u003eRust output is\nformatted. It uses the rustfmt binary from fuchsia/prebuilts, and the\nconfing file fuchsia/rustfmt.toml.\n\nThis also removes logic in main.go to determine default values for flags\nbecause it is outdated (e.g. assumes fidlbolt is in the fuchsia tree)\nand these defaults are already set in the Makefile.\n\nChange-Id: I7942de31f14b39c58ffcc5b4bb97e5d0472ac878\n" }, { "commit": "6f3a32380c95fbb42790e1fe9fda29cb5836a0f7", "tree": "139dba74edf705305e531e5cdc8e06b76eb82d05", "parents": [ "eeaa2cc9491abfa1ff559304ee3e2ebd3ea0f118" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Mar 30 09:13:00 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Mon Mar 30 09:15:26 2020 -0700" }, "message": "Fix bug where \"Reset all data\" did not work\n\nThe \"Reset all data\" button was not working because the Evaluator always\nsaves to local storage on the browser \"unload\" event. This CL fixes that\nby stopping the evaluator before clearing local storage and refreshing\n(when the user clicks the \"Reset all data\" button).\n\nChange-Id: I71405c08f8150ae5f872cb297bbb22e178136556\n" }, { "commit": "eeaa2cc9491abfa1ff559304ee3e2ebd3ea0f118", "tree": "2b7dc125595a5725dc581a8a0440b7e1e9c30519", "parents": [ "78f669c91a5200f5369484d86b0b59ee3188ce46" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Fri Mar 27 22:52:03 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Fri Mar 27 22:52:03 2020 -0700" }, "message": "Add support for parsing lists of decimal bytes\n\nThis CL changes the byte parsing code to allow lists of individual bytes\n(interpreted in decimal without prefixes), and makes it ignore line\noffsets at the start of lines.\n\nMy goal is to make the input very flexible: it should be easy to just\npaste in the output of a failing GIDL test. At the same time, it should\nbe idempotent so that you can paste the output tab back into the input\ntab. This means by default parsing xxd style hex values, but also\nproviding a way to list bytes in decimal (in addition to the other\nniceties like strings and little-endian integers).\n\nChange-Id: Idf74bca619141d767c907b3b8485d9d979aa9675\n" }, { "commit": "78f669c91a5200f5369484d86b0b59ee3188ce46", "tree": "8ad542ae4686d98597f0122bb018b69d7fb544e4", "parents": [ "c6f8931e3ac7350c2ee86371f50f7a84ccecfc7d" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Fri Mar 27 20:13:32 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Fri Mar 27 20:13:32 2020 -0700" }, "message": "Do not save form inputs until changed by the user\n\nThis CL refactors the Form module to not persist default input values to\nlocal storage unless the user has explicitly set them to those values.\nThis means that if a new version of fidlbolt changes a default, it will\nbe changed for users who never touched that setting before. Others will\nretain their chosen setting (and always have the option of clicking the\n\"Use Defaults\" button).\n\nThis also refactors the Settings model to store preferredScheme\nseparately rather than tacking it onto the Form model.\n\nChange-Id: I3a0ba3e176922beb86f124feaecf6df7a03df126\n" }, { "commit": "c6f8931e3ac7350c2ee86371f50f7a84ccecfc7d", "tree": "742ef83dafecc2c97aaba0006d92387180cb63fd", "parents": [ "135a4921f30f5b250821872e9f7d964c532aad5c" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Fri Mar 27 13:51:42 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Fri Mar 27 13:51:42 2020 -0700" }, "message": "Remove emojis and Bytes+ tabs\n\n* The emojis looked bad on Linux. Rather than try to use images or a\n webfont, we have decided to simply remove them. The \"fidlbolt\" heading\n stands on its own nicely.\n\n* I have removed the Bytes+ tab for now because it is not implemented\n (and won\u0027t be for a while). FIDL Text tabs are not implemented either,\n but it\u0027s at least obvious what they should do, and we will probably\n implement them sooner than Bytes+.\n\nChange-Id: I7eae1d9c4da8ac46b23eef914cddbbc2cf950a48\n" }, { "commit": "135a4921f30f5b250821872e9f7d964c532aad5c", "tree": "a606bdee1cc8dba8f4d59a624ef3b5a26ade3701", "parents": [ "5679cab8102c19a0171e8ab90dc84719d5987db4" ], "author": { "name": "Yifei Teng", "email": "yifeit@google.com", "time": "Mon Mar 23 16:51:46 2020 -0700" }, "committer": { "name": "Yifei Teng", "email": "yifeit@google.com", "time": "Mon Mar 23 16:51:46 2020 -0700" }, "message": "Create `.gcloudignore` as a symlink to `.dockerignore`\n\nThis teachs gcloud to use the docker ignore file, as opposed to picking\nup from .gitignore\n" }, { "commit": "5679cab8102c19a0171e8ab90dc84719d5987db4", "tree": "d74e354b2676df32f76be0afe9d8ea266828e6ca", "parents": [ "c2d9db411b015bd9a48c13af466d11bc4b14b235" ], "author": { "name": "Yifei Teng", "email": "yifeit@google.com", "time": "Mon Mar 23 16:17:55 2020 -0700" }, "committer": { "name": "Yifei Teng", "email": "yifeit@google.com", "time": "Mon Mar 23 16:17:55 2020 -0700" }, "message": "Run `npm ci` instead of `npm install` when deploying\n\nTo ensure reproducible builds.\n" }, { "commit": "c2d9db411b015bd9a48c13af466d11bc4b14b235", "tree": "c12a70f703d9f326df235f69f6c715b9ebf0e82c", "parents": [ "65d4d9dd59c5716cca77ffcf5374c45e5beebb9f" ], "author": { "name": "Yifei Teng", "email": "yifeit@google.com", "time": "Mon Mar 23 14:08:59 2020 -0700" }, "committer": { "name": "Yifei Teng", "email": "yifeit@google.com", "time": "Mon Mar 23 14:08:59 2020 -0700" }, "message": "Use `npm ci` instead of `npm install` when building.\n\nThis stops accidentally updating packages, and strictly uses what\u0027s in\npackage-lock.json. We can manually update packages/locks using `npm\ninstall` when developing.\n" }, { "commit": "65d4d9dd59c5716cca77ffcf5374c45e5beebb9f", "tree": "12e1b6ed826e0a92f583dd55c5bd90f8b52a86a5", "parents": [ "58de55161baf0a4c1575b9752b88d79501dbe9ff" ], "author": { "name": "Yifei Teng", "email": "yifeit@google.com", "time": "Mon Mar 23 13:34:51 2020 -0700" }, "committer": { "name": "Yifei Teng", "email": "yifeit@google.com", "time": "Mon Mar 23 13:34:51 2020 -0700" }, "message": "Show an error when FUCHSIA_DIR is not defined.\n\nTEST: Manually ran `make run` without FUCHSIA_DIR\n" }, { "commit": "58de55161baf0a4c1575b9752b88d79501dbe9ff", "tree": "7385946d0966076bafe69e6bb95774dbfc4ce718", "parents": [ "2cee5f8502fb20b03e1befb666b371516111722e" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Mar 19 13:20:30 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Mar 19 13:22:12 2020 -0700" }, "message": "Rename support/ to fuchsia/ and improve Makefile\n" }, { "commit": "2cee5f8502fb20b03e1befb666b371516111722e", "tree": "9e9632b817143a51e8ddcfa3a39d4d8371edd9b4", "parents": [ "1cbb8d3dcfab12e78b40050c78420785c50705de" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Mar 19 12:45:49 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Mar 19 12:45:49 2020 -0700" }, "message": "Use exec.CommandContext insead of manually killing process\n" }, { "commit": "1cbb8d3dcfab12e78b40050c78420785c50705de", "tree": "84cad32ae183ffb2d714d211ed56c331d5c903d4", "parents": [ "01a6b8541e813b05939a6d75d52fe69802b73cc1" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Mar 19 11:37:14 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Mar 19 11:37:14 2020 -0700" }, "message": "Address Pascal\u0027s comments from fxr/365760\n\nhttps://fuchsia-review.googlesource.com/c/fuchsia/+/365760\n" }, { "commit": "01a6b8541e813b05939a6d75d52fe69802b73cc1", "tree": "0785d3084dc1a6f366268f9fa0d15f9affbade5e", "parents": [ "b7c9e8253870ae383195e9d932fa1e0f4fbd996f" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Mar 19 11:27:17 2020 -0700" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Mar 19 11:27:17 2020 -0700" }, "message": "fixup ctrl-l\n" } ], "next": "b7c9e8253870ae383195e9d932fa1e0f4fbd996f" }