tree 8d503b36ffc4e8ee8d4bc450a8131a97c41ed177
parent b4f2968c9e6f790a18901fb64ac5170651e640fc
author Alex Zaslavsky <azaslavsky@google.com> 1668805657 +0000
committer Alex Zaslavsky <azaslavsky@google.com> 1668805657 +0000

[vscode] Fix alias and const LHS type highlighting

Previously, the type on the LHS of the `const` declaration was tagged
(and therefore colored) the same way as a constant value,
`storage.type`.  This was simply incorrect.

The `alias` case is a bit more interesting: while the `variable.alias`
tag is probably more correct than the new `entity.name.type`
semantically, the highlighting it produced was a bit confusing. Aliases
names were a different color from other types at their declaration
sites, but not at their use sites, causing confusion. Since textMate
grammar is not able to deduce whether a name is resolved through an
alias or not, its best to just use one color for all "things that refer
to types" in all positions.

Fixed: 99302
Change-Id: I8fdd0ed5cf2ef1a546456a8d9cf20e4c789e35c3
Reviewed-on: https://fuchsia-review.googlesource.com/c/fidl-misc/+/762857
Reviewed-by: Zachary Stewart <zstewart@google.com>