tree 5203fc7e2e01f179000b43b3e931073d950ab6b7
parent bd3969744836080a48f851a2385dcbc5989c1381
author Zach Bush <zmbush@google.com> 1636655466 +0000
committer releases-try-builder <releases-try-builder@fuchsia-infra.iam.gserviceaccount.com> 1636667466 +0000

[LocalAggregateStorage] Always write before shutdown

- Makes sure that the shut down only occurs _after_ a write.
- Adds condition variable 'shutdown_complete_notifier' so ShutDown can
  return early if the shutdown takes too long.
- ~DelayedLocalAggregateStorage() still waits for the thread to join for
  a clean shutdown.

Ran 300 times on local fuchsia device with no errors.
Ran 300 times on standalone linux build with no errors.

Tested-With: fx test cobalt_core_tests -- --gtest_filter="DelayedLocalAggregateStorageTest.ShutDownIsFast" --gtest_repeat=300
Tested-With: ./cobaltb.py build && out/tests/cpp/cobalt_core_tests --gtest_filter=DelayedLocalAggregateStorageTest.ShutDownIsFast --gtest_repeat=300
Bug: 88444
Bug: 86668
Change-Id: Ic0c898a6ee9b2cea32f97dbad841fd47d2d585ce
Reviewed-on: https://fuchsia-review.googlesource.com/c/cobalt/+/604944
Fuchsia-Auto-Submit: Zach Bush <zmbush@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Reviewed-by: Cameron Dale <camrdale@google.com>