commit | babfbe233ac9ea168f824c5359406d4f0ff703aa | [log] [tgz] |
---|---|---|
author | Laura Peskin <pesk@google.com> | Thu Feb 18 13:26:45 2021 +0000 |
committer | CQ Bot <commit-bot@chromium.org> | Thu Feb 18 13:26:45 2021 +0000 |
tree | 7effe5b22c8347defba22f65d512009fe6d72baa | |
parent | eab4915929601700edbc72683ac86d7275d30342 [diff] |
[config_validator] Change numeric bounds validation to match PrivacyEncoder usage Makes a few changes to bring config validation into line with what is expected by the PrivacyEncoder and privacy encoding params calculator: - min_value and/or max_value is required for FleetwideOccurrenceCounts with added privacy - max_count is required for FleetwideHistograms with added privacy - no bounds are required for UniqueDeviceHistograms and HourlyValueHistograms with added privacy In a follow-up, uses of min_value, max_value, and max_count are forbidden when not required (e.g. for reports without added privacy). DO NOT SUBMIT until https://fxrev.dev/486960 has rolled. Bug: 70382 Change-Id: I70c6a327bffc24527365a9ccaa14119d192ba9ee Reviewed-on: https://fuchsia-review.googlesource.com/c/cobalt/+/487001 Commit-Queue: Laura Peskin <pesk@google.com> Reviewed-by: Zach Bush <zmbush@google.com>
Cobalt is a pipeline for collecting metrics data from user-owned devices in the field and producing aggregated reports.
Cobalt includes a suite of features for preserving user privacy and anonymity while giving product owners the data they need to improve their products.
The code in the Git repo at https://fuchsia.googlesource.com/cobalt is known as Cobalt Core. It contains:
In order to have a working Cobalt system you need to also have
//third_party/cobalt
.This document describes how to develop, build and test Cobalt Core independently of Fuchsia.
For example via
git clone https://fuchsia.googlesource.com/cobalt
cd cobalt
./cobaltb.py setup
This will take a few minutes the first time. It does the following:
third_party
dir via Git submodules.sysroot
dir. This uses CIPD.The Python script cobaltb.py
in the root directory is used to orchestrate building and testing Cobalt. It was already used above in ./cobaltb.py setup
.
./cobaltb.py -h
for general helpcobaltb.py <command> -h
for help on a command./cobaltb.py build
The Cobalt build uses GN and ninja.
./cobaltb.py test
./cobaltb.py fmt
./cobaltb.py lint
See: clang-tidy for an explanation of clang-tidy configuration options.
Cobalt uses the Gerrit code review tool. Although Cobalt Core is independent of Fuchsia, we do share infrastructure with Fucshia and so much of the instructions from Fuchsia's Contributing Guide apply to Cobalt Core. The main difference is that Cobalt Core does not use Jiri--it uses Git submodules instead.
Follow the instructions here.
To create a change in Gerrit do the following:
cd ~/cobalt
git checkout -b <branch_name>
git add <files>
git commit
git push origin HEAD:refs/for/master
See the Gerrit documentation for more information.
After creating a change, to upload a patch to your change, do the following:
git add <files>
--amend
option: git commit --amend
git push origin HEAD:refs/for/master