commit | 4a681cc5427f45144e12c8ff8e91900f3dccb511 | [log] [tgz] |
---|---|---|
author | Zach Bush <zmbush@google.com> | Thu Jul 08 19:44:59 2021 +0000 |
committer | CQ Bot <commit-bot@chromium.org> | Thu Jul 08 19:44:59 2021 +0000 |
tree | 786f10071443f1484c3f393792dbb56812d13168 | |
parent | 58601f7c645f31f61d7cae93ac8146fa2cc8a6df [diff] |
[EventLogger] Fix duplicated logging Cobalt 1.1 would log to each report a number of times equal to the number of reports in a metric. This change fixes that, so that each report is logged to only once. Additionally, found bug in implementation of UNIQUE_DEVICE_HISTOGRAMS, and UNIQUE_DEVICE_NUMERIC_STATS, where the values would be aggregated as hourly, instead of daily. Change-Id: I402ca8f322846ce6d5f3f42b9a83c93f4989763e Reviewed-on: https://fuchsia-review.googlesource.com/c/cobalt/+/552530 Reviewed-by: Cameron Dale <camrdale@google.com> Reviewed-by: Alexandre Zani <azani@google.com> Commit-Queue: Zach Bush <zmbush@google.com>
Cobalt is a pipeline for collecting metrics data from user-owned devices in the field and producing aggregated reports.
Cobalt includes a suite of features for preserving user privacy and anonymity while giving product owners the data they need to improve their products.
The code in the Git repo at https://fuchsia.googlesource.com/cobalt is known as Cobalt Core. It contains:
In order to have a working Cobalt system you need to also have
//third_party/cobalt
.This document describes how to develop, build and test Cobalt Core independently of Fuchsia.
For example via
git clone https://fuchsia.googlesource.com/cobalt
cd cobalt
./cobaltb.py setup
This will take a few minutes the first time. It does the following:
third_party
dir via Git submodules.sysroot
dir. This uses CIPD.The Python script cobaltb.py
in the root directory is used to orchestrate building and testing Cobalt. It was already used above in ./cobaltb.py setup
.
./cobaltb.py -h
for general helpcobaltb.py <command> -h
for help on a command./cobaltb.py build
The Cobalt build uses GN and ninja.
./cobaltb.py test
./cobaltb.py fmt
./cobaltb.py lint
See: clang-tidy for an explanation of clang-tidy configuration options.
Cobalt uses the Gerrit code review tool. Although Cobalt Core is independent of Fuchsia, we do share infrastructure with Fucshia and so much of the instructions from Fuchsia's Contributing Guide apply to Cobalt Core. The main difference is that Cobalt Core does not use Jiri--it uses Git submodules instead.
Follow the instructions here.
To create a change in Gerrit do the following:
cd ~/cobalt
git checkout -b <branch_name>
git add <files>
git commit
git push origin HEAD:refs/for/main
See the Gerrit documentation for more information.
After creating a change, to upload a patch to your change, do the following:
git add <files>
--amend
option: git commit --amend
git push origin HEAD:refs/for/main