commit | 618822f5a1ea070e71d99897f25d857b12d13aec | [log] [tgz] |
---|---|---|
author | Cameron Dale <camrdale@google.com> | Fri Apr 30 03:41:26 2021 +0000 |
committer | CQ Bot <commit-bot@chromium.org> | Fri Apr 30 03:41:26 2021 +0000 |
tree | 57c8e3fb1e8f05e50593a54a67c410e6784ba474 | |
parent | 3f0900780aff6508ebac856a5b6382a07a4cb496 [diff] |
Replace a global map with a switch statement. Internally, this global map causes unit tests to fail as we have a heap checker installed that doesn't like this. For details, see go/totw/50. Since this map was only used in one place, I replaced with a switch statement. Bug: b/144802812 Change-Id: I53083f2be254fa5d182796c44447bf6dbb10c66b Reviewed-on: https://fuchsia-review.googlesource.com/c/cobalt/+/522451 Fuchsia-Auto-Submit: Cameron Dale <camrdale@google.com> Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com> Reviewed-by: Jared Weinstein <jaredweinstein@google.com>
Cobalt is a pipeline for collecting metrics data from user-owned devices in the field and producing aggregated reports.
Cobalt includes a suite of features for preserving user privacy and anonymity while giving product owners the data they need to improve their products.
The code in the Git repo at https://fuchsia.googlesource.com/cobalt is known as Cobalt Core. It contains:
In order to have a working Cobalt system you need to also have
//third_party/cobalt
.This document describes how to develop, build and test Cobalt Core independently of Fuchsia.
For example via
git clone https://fuchsia.googlesource.com/cobalt
cd cobalt
./cobaltb.py setup
This will take a few minutes the first time. It does the following:
third_party
dir via Git submodules.sysroot
dir. This uses CIPD.The Python script cobaltb.py
in the root directory is used to orchestrate building and testing Cobalt. It was already used above in ./cobaltb.py setup
.
./cobaltb.py -h
for general helpcobaltb.py <command> -h
for help on a command./cobaltb.py build
The Cobalt build uses GN and ninja.
./cobaltb.py test
./cobaltb.py fmt
./cobaltb.py lint
See: clang-tidy for an explanation of clang-tidy configuration options.
Cobalt uses the Gerrit code review tool. Although Cobalt Core is independent of Fuchsia, we do share infrastructure with Fucshia and so much of the instructions from Fuchsia's Contributing Guide apply to Cobalt Core. The main difference is that Cobalt Core does not use Jiri--it uses Git submodules instead.
Follow the instructions here.
To create a change in Gerrit do the following:
cd ~/cobalt
git checkout -b <branch_name>
git add <files>
git commit
git push origin HEAD:refs/for/master
See the Gerrit documentation for more information.
After creating a change, to upload a patch to your change, do the following:
git add <files>
--amend
option: git commit --amend
git push origin HEAD:refs/for/master