commit | f93d622df69dc7306ff50894583ca7d4effe1120 | [log] [tgz] |
---|---|---|
author | Laura Peskin <pesk@google.com> | Tue Mar 16 17:20:49 2021 +0000 |
committer | CQ Bot <commit-bot@chromium.org> | Tue Mar 16 17:20:49 2021 +0000 |
tree | 0cbdb85efad08c3ce7aa3516d6cb3a96411b615f | |
parent | 67c67573191f18e896c5920860289bd90ae8e5ac [diff] |
[observation] Update comments to require bucket_indices in IndexHistogram Previously, the comment on IndexHistogram allowed two different patterns: (1) Both of the repeated fields bucket_indices and bucket_counts are populated, and bucket_counts[i] is the count for index bucket_indices[i]. (2) Only bucket_counts is populated and bucket_counts[i] is the count for index i. In practice we only use (1), so this removes (2) from the comment. Change-Id: Ie1f2f3f3b374c7ea8461c331cf57b3a970ee6a5b Reviewed-on: https://fuchsia-review.googlesource.com/c/cobalt/+/499958 Reviewed-by: Cameron Dale <camrdale@google.com> Reviewed-by: Alexandre Zani <azani@google.com> Commit-Queue: Laura Peskin <pesk@google.com>
Cobalt is a pipeline for collecting metrics data from user-owned devices in the field and producing aggregated reports.
Cobalt includes a suite of features for preserving user privacy and anonymity while giving product owners the data they need to improve their products.
The code in the Git repo at https://fuchsia.googlesource.com/cobalt is known as Cobalt Core. It contains:
In order to have a working Cobalt system you need to also have
//third_party/cobalt
.This document describes how to develop, build and test Cobalt Core independently of Fuchsia.
For example via
git clone https://fuchsia.googlesource.com/cobalt
cd cobalt
./cobaltb.py setup
This will take a few minutes the first time. It does the following:
third_party
dir via Git submodules.sysroot
dir. This uses CIPD.The Python script cobaltb.py
in the root directory is used to orchestrate building and testing Cobalt. It was already used above in ./cobaltb.py setup
.
./cobaltb.py -h
for general helpcobaltb.py <command> -h
for help on a command./cobaltb.py build
The Cobalt build uses GN and ninja.
./cobaltb.py test
./cobaltb.py fmt
./cobaltb.py lint
See: clang-tidy for an explanation of clang-tidy configuration options.
Cobalt uses the Gerrit code review tool. Although Cobalt Core is independent of Fuchsia, we do share infrastructure with Fucshia and so much of the instructions from Fuchsia's Contributing Guide apply to Cobalt Core. The main difference is that Cobalt Core does not use Jiri--it uses Git submodules instead.
Follow the instructions here.
To create a change in Gerrit do the following:
cd ~/cobalt
git checkout -b <branch_name>
git add <files>
git commit
git push origin HEAD:refs/for/master
See the Gerrit documentation for more information.
After creating a change, to upload a patch to your change, do the following:
git add <files>
--amend
option: git commit --amend
git push origin HEAD:refs/for/master