[roll] Roll third_party/fuchsia-infra-bazel-rules [roll] Roll third_party/googletest Improve the failure messages of `ElementsAre()`, `ElementsAreArray()`, etc.
NOTE: if you suspect that this change breaks your build, it's likely that your tests depend on the exact messages of `ElementsAre()` and friends. The messages are implementation details of these matcher and are subject to change without notice. Depending on the messages is not supported. In that case, please rewrite your tests to avoid the dependency.
When the array being matched is long, it can be hard for the user to find the mismatched element in the message generated by `ElementsAre()` or `ElementsAreArray()` - even though these matchers print the index of the mismatched element, the user still has to count to find the actual element and its corresponding matcher.
With this change, these matchers will include the actual value and corresponding matcher in the failure message, making it easier for the user.
Also make a small style improvement: now it's advised to write
```
EXPECT_EQ(actual, expected);
```
as opposed to
```
EXPECT_EQ(expected, actual);
```
PiperOrigin-RevId: 738039133
Original-Revision: 3af834740f58ef56058e6f8a1be51f62bc3a6515
Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia-infra-bazel-rules/+/1231049
Original-Revision: e561eff830ce44adb9854b883db250ef63f91a58
Roller-URL: https://cr-buildbucket.appspot.com/build/8720041962788385377
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: Ia551e60bccb871d90549bf53210e9230dfc5a790
Reviewed-on: https://fuchsia-review.googlesource.com/c/boards/emac/+/1231010
Commit-Queue: GI Roller <global-integration-roller@fuchsia-infra.iam.gserviceaccount.com>
1 file changed