tree 960eb875f5637140e8aa3c4889b66e5cbe16e0a3
parent 5853e92207193e967abf5e4c25b4a551c7604725
author Daniel P. Berrange <berrange@redhat.com> 1508491119 +0100
committer Daniel P. Berrange <berrange@redhat.com> 1510063820 +0000

sockets: avoid leak of listen file descriptor

If we iterate over the full port range without successfully binding+listening
on the socket, we'll try the next address, whereupon we overwrite the slisten
file descriptor variable without closing it.

Rather than having two places where we open + close socket FDs on different
iterations of nested for loops, re-arrange the code to always open+close
within the same loop iteration.

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>